Hello,
My app is missing screenshots - I thought it was a temporary issue with Flathub when publishing the initial version but the problem persists after publishing a new version - I have no idea why.
GNOME Software displays the screenshot properly when I use a local remote to preview.
https://flathub.org/apps/details/re.sonny.Junction
Any idea?
It might be a problem with the aspect ratio and resizing, read here:
opened 09:13PM - 16 May 18 UTC
closed 01:10AM - 31 May 18 UTC
@jgarciao I was told to ping you. The issue is just what the tittle says... Gnom… e software shows the preview thumbnails, but it also lacks the "big" screenshots. Flathub doesn't show neither one
@fedelibre thanks but it looks unrelated
I took some time to investigate - looks like downloading the screenshots from Github fails with SSL handshake failed
here is what the build reports
Mirroring screenshots from appdata
e]2;flatpak-builder: Mirroring screenshotsaFB: Running: flatpak build --die-with-parent --nofilesystem=host --filesystem=/srv/buildbot/worker/build-x86_64/build/builddir --filesystem=/srv/buildbot/worker/build-x86_64/build/.flatpak-builder/screenshots-cache --share=network /srv/buildbot/worker/build-x86_64/build/builddir appstream-util mirror-screenshots /srv/buildbot/worker/build-x86_64/build/builddir/files/share/app-info/xmls/re.sonny.Junction.xml.gz https://dl.flathub.org/repo/screenshots/re.sonny.Junction-stable /srv/buildbot/worker/build-x86_64/build/.flatpak-builder/screenshots-cache /srv/buildbot/worker/build-x86_64/build/builddir/screenshots/re.sonny.Junction-stable
re.sonny.Junction: Downloading https://raw.githubusercontent.com/sonnyp/Junction/main/data/screenshot.png
re.sonny.Junction: Failed to download https://raw.githubusercontent.com/sonnyp/Junction/main/data/screenshot.png: Downloading failed: SSL handshake failed
re.sonny.Junction: Downloading https://raw.githubusercontent.com/sonnyp/Junction/main/data/screenshot-file.png
re.sonny.Junction: Failed to download https://raw.githubusercontent.com/sonnyp/Junction/main/data/screenshot-file.png: Downloading failed: SSL handshake failed
re.sonny.Junction: Downloading https://raw.githubusercontent.com/sonnyp/Junction/main/data/screenshot-shortcuts.png
re.sonny.Junction: Failed to download https://raw.githubusercontent.com/sonnyp/Junction/main/data/screenshot-shortcuts.png: Downloading failed: SSL handshake failed
Saved screenshots in /srv/buildbot/worker/build-x86_64/build/builddir/screenshots
https://flathub.org/builds/#/builders/48/builds/8402/steps/6/logs/stdio
It’s quite strange since one of my other app which does exactly the same thing doesn’t fail
Mirroring screenshotsaFB: Running: flatpak build --die-with-parent --nofilesystem=host --filesystem=/srv/buildbot/worker/build-x86_64-5/build/builddir --filesystem=/srv/buildbot/worker/build-x86_64-5/build/.flatpak-builder/screenshots-cache --share=network /srv/buildbot/worker/build-x86_64-5/build/builddir appstream-util mirror-screenshots /srv/buildbot/worker/build-x86_64-5/build/builddir/files/share/app-info/xmls/re.sonny.Commit.xml.gz https://dl.flathub.org/repo/screenshots/re.sonny.Commit-stable /srv/buildbot/worker/build-x86_64-5/build/.flatpak-builder/screenshots-cache /srv/buildbot/worker/build-x86_64-5/build/builddir/screenshots/re.sonny.Commit-stable
re.sonny.Commit: Downloading https://raw.githubusercontent.com/sonnyp/Commit/main/data/screenshot-light.png
re.sonny.Commit: Saved to cache /srv/buildbot/worker/build-x86_64-5/build/.flatpak-builder/screenshots-cache/re.sonny.Commit-screenshot-light.png
re.sonny.Commit: Downloading https://raw.githubusercontent.com/sonnyp/Commit/main/data/emoji.png
re.sonny.Commit: Saved to cache /srv/buildbot/worker/build-x86_64-5/build/.flatpak-builder/screenshots-cache/re.sonny.Commit-emoji.png
re.sonny.Commit: Downloading https://raw.githubusercontent.com/sonnyp/Commit/main/data/screenshot-dark.png
re.sonny.Commit: Saved to cache /srv/buildbot/worker/build-x86_64-5/build/.flatpak-builder/screenshots-cache/re.sonny.Commit-screenshot-dark.png
re.sonny.Commit: Downloading https://raw.githubusercontent.com/sonnyp/Commit/main/data/welcome-light.png
re.sonny.Commit: Saved to cache /srv/buildbot/worker/build-x86_64-5/build/.flatpak-builder/screenshots-cache/re.sonny.Commit-welcome-light.png
re.sonny.Commit: Downloading https://raw.githubusercontent.com/sonnyp/Commit/main/data/welcome-dark.png
re.sonny.Commit: Saved to cache /srv/buildbot/worker/build-x86_64-5/build/.flatpak-builder/screenshots-cache/re.sonny.Commit-welcome-dark.png
Saved screenshots in /srv/buildbot/worker/build-x86_64-5/build/builddir/screenshots
https://flathub.org/builds/#/builders/35/builds/8435/steps/6/logs/stdio
It sounds like GitHub is rate limiting you or something. But it’s strange it’s giving you an SSL error.
Not sure what makes you think rate limiting is at play here?
Anyway - it looks like an issue on flathub’s infrastructure and I can’t do much about it - would be great if someone who can had a look.
I try hosting the screenshots somewhere else - same result
Mirroring screenshots from appdata
e]2;flatpak-builder: Mirroring screenshotsaFB: Running: flatpak build --die-with-parent --nofilesystem=host --filesystem=/srv/buildbot/worker/build-x86_64-3/build/builddir --filesystem=/srv/buildbot/worker/build-x86_64-3/build/.flatpak-builder/screenshots-cache --share=network /srv/buildbot/worker/build-x86_64-3/build/builddir appstream-util mirror-screenshots /srv/buildbot/worker/build-x86_64-3/build/builddir/files/share/app-info/xmls/re.sonny.Junction.xml.gz https://dl.flathub.org/repo/screenshots/re.sonny.Junction-test /srv/buildbot/worker/build-x86_64-3/build/.flatpak-builder/screenshots-cache /srv/buildbot/worker/build-x86_64-3/build/builddir/screenshots/re.sonny.Junction-test
re.sonny.Junction: Downloading https://junction.sonny.re/screenshot.png
re.sonny.Junction: Failed to download https://junction.sonny.re/screenshot.png: Downloading failed: SSL handshake failed
re.sonny.Junction: Downloading https://junction.sonny.re/screenshot-file.png
re.sonny.Junction: Failed to download https://junction.sonny.re/screenshot-file.png: Downloading failed: SSL handshake failed
re.sonny.Junction: Downloading https://junction.sonny.re/screenshot-shortcuts.png
re.sonny.Junction: Failed to download https://junction.sonny.re/screenshot-shortcuts.png: Downloading failed: SSL handshake failed
Saved screenshots in /srv/buildbot/worker/build-x86_64-3/build/builddir/screenshots
https://flathub.org/builds/#/builders/39/builds/8525/steps/6/logs/stdio
Removing GLib from the flatpak manifest fixes the SSL handhsake issue.
https://github.com/flathub/re.sonny.Junction/pull/3/commits/5dd95eb3e8c62e548be1622ea40b818d5c72dc43
I’m a bit confused how or why it is affecting flatpak-builder.
Problem solved
See
committed 02:34PM - 16 Dec 21 UTC
On flathub.org/builds - appstream-util mirror screenshots runs in the sandbox w… here glib fails to load glib-networking. Bundling glib-networking fixes the problem.
https://discourse.flathub.org/t/missing-screenshots/1852/6
There is a WIP PR that moves this outside of the sandbox
https://github.com/flatpak/flatpak-builder/pull/418
and
https://matrix.to/#/!RfXaBjokqHAbzZrgHz:matrix.org/$aGMJI2eKuQ9d1tHmsEJWR2Sr3aTHKTztBT_oNGRFaew?via=matrix.org&via=gnome.org