How to apply patch from the remote source to module?

1

I want to apply this patch in the Flatpak manifest, without creating local copy of the file.

I’m reading documentation section but there is nothing about the remote source (not git, but file source)

Must I create shell script for that, or some option exist for the manifest file?

In other words, I want something like that:

...
"modules": [
{
    "name": "libdb",
    "buildsystem": "simple",
    "build-commands": [
        "cd build_unix && ../dist/configure --prefix=/app/libdb --enable-cxx && make && make install"
    ],
    "sources": [
        {
            "type": "archive",
            "url": "https://download.oracle.com/berkeley-db/db-4.8.30.tar.gz",
            "sha256": "e0491a07cdb21fb9aa82773bbbedaeb7639cbd0e7f96147ab46141e0045db72a"
        },
        {
                "type": "patch",
            --> "path": "https://gist.githubusercontent.com/LnL7/5153b251fd525fe15de69b67e63a6075/raw/7778e9364679093a32dec2908656738e16b6bdcb/clang.patch"
        }
    ]
},
...

Thoughts about this option, not sure it is correct:

"build-commands": [
    "http_get https://gist.githubusercontent.com/LnL7/5153b251fd525fe15de69b67e63a6075/raw/7778e9364679093a32dec2908656738e16b6bdcb/clang.patch clang.patch 7a9a47b03fd5fb93a16ef42235fa9512db9b0829cfc3bdf90edd3ec1f44d637c",
    "patch -p2 < clang.patch",
    "cd build_unix && ../dist/configure --prefix=/app/libdb --enable-cxx && make && make install"
],
2

A patch needs to be come from a local file. Right now, there is no url option for it.

This will definitely not work. Flatpak Builder first loads and caches all sources, and then builds offline.

I’d say just provide the patch in the folder with your manifest. Its the simplest and best solution.

Also, on another note:
You set the prefix to /app/libdb in your configure. While Flatpak uses a special prefix for apps, it still follows the other Linux filesystem conventions, so binaries should go to /app/bin, libraries to /app/lib and data files under /app/share/libdb.
Its best you ensure this is the case after build. You can check this by looking at the filetree of the build folder after an successful build, as this shows anything the app will have in its /app prefix.

1 Like
3

Thank you much for this correction!

Right now I’m trying to solve (maybe) related issue, when the app get compiled successfully, but launching with this linking error:
libboost_filesystem.so cannot open shared object file: No such file or directory

  • it is my first experience with Flatpak
4

May be related to what I pointed out with the prefix.

Library files will be expected to be under /app/lib, so if you have installed them elsewhere, they won’t be found.

1 Like
5

Yes, I can confirm now - fixed --prefix= and other paths to /app and all files delivered to the correct destinations! Thanks!