I’ve spent this last month making a new application called Symbolical, and now i felt that it was ready for a first release.
So.. I’ve never tried to publish an app to flathub before. I read the requirements and the submission process documentation, but then i made a few mistakes during my submission. I admitted so and tried to fix the errors i made and then before i even got to pushing my corrections i get this last response.:
Quote “It’s supposed to be in the folder when you are slopping your way through the PR. Don’t bother with a second slop submission not following requirements”
The Pull Request got closed and it seems my best efforts at trying to publish the app is now slop. And that i shouldn’t try to do it again.
my mistake was.. I put the manifest in a folder.. I was supposed to put it at the top level.. I added to many files to the submission. And i named the pull request wrong closed it and made a new one with the correct name.
I did ask chatgpt for some help during the process, but i wrote the entire manifest myself and i tested it.. It built and passed the initial automated testing. so.. huh.
The main issue you made was closing your first PR after the bot found an issue, and then making a new one that still had some of the issues the bot pointed out.
We nowadays receive many slop submissions. And one common tactic amongst them is to close old PRs when issues arise and then to open a new one with the same issues. Probably hoping that with enough spam they manage to get through the process at some point.
And at some point it is just exhausting for us reviewers. So, sometimes we tend to have short fuses when it comes to closing submissions where we don’t believe the developer is putting effort in.
I’ll give you a second chance and re-open the last PR. But I do expect you properly fixing all issues in that PR.
Its not like i didn’t show an effort of asking into what my mistakes was.
So do i just commit and push my fixes to the same branch?
If the branch is locked how will it work?
As for merge being locked:
Since every app manifest gets their own repository upon approval, Flathub does not use the Git merge, but its own merge pipeline. Git merges are locked to prevent accidentally altering the Flathub submissions repository.
The new-pr branch?
But i branched that into a new branch named symbolical-app-submission to make my PR.
How does it make sense to push changes to the new-pr branch?
The new-pr branch is the target branch of your PR. If your branch in the fork is called symbolical-app-submission, then push the changes to this branch.
The main point: Don’t open new PRs for the same submission.
I will rearrange the files in my project repo to make better place for all these files. I also forgot to add the license notifications in the app itself, so I need to make some changes there also. Thanks for the help.
