Trying to get x-checker-data to work: No PR?

1

Hi there! I’m new to packaging and I’m collaborating on the Mindustry flatpak. Recently, we’ve succeeded in building this libGDX game from source with a script that generates the Gradle sources (only the beta branch though).

Because this now allows to use the x-checker-data property to automatically update the flatpak, we tried that. However, just 5 days ago (and 3 days ago again), a new version got released, but there was no PR.

I ran the flatpak-external-data-checker locally, and it picked up on the new version:

~/p/f/com.github.Anuken.Mindustry > flatpak run org.flathub.flatpak-external-data-checker --check-outdated com.github.Anuken.Mindustry.yml                                                      0.492s  (beta) 14:04
INFO    src.manifest: Loading sources from gradle-sources.json
INFO    src.manifest: Checking 238 external data items
INFO    src.manifest: Started check [1/238] git Mindustry (from com.github.Anuken.Mindustry.yml)
INFO    src.manifest: Skipped check [2/238] file gradle-7.3-bin.zip (from com.github.Anuken.Mindustry.yml)
INFO    src.manifest: Skipped check [3/238] file asm-3.3.1.pom (from gradle-sources.json)
INFO    src.manifest: Skipped check [4/238] file asm-3.3.1.jar (from gradle-sources.json)
INFO    src.manifest: Skipped check [5/238] file asm-parent-3.3.1.pom (from gradle-sources.json)
[...]
INFO    src.manifest: Skipped check [237/238] file annotations-13.0.pom (from gradle-sources.json)
INFO    src.manifest: Skipped check [238/238] file annotations-13.0.jar (from gradle-sources.json)
INFO    src.lib.externaldata: Source Mindustry: got new version 135.2
INFO    src.manifest: Finished check [238/238] git Mindustry (from com.github.Anuken.Mindustry.yml)
CHANGE SOON: Mindustry
 Has a new version:
  URL:       https://github.com/Anuken/Mindustry
  Commit:    41b22ba6a64b748b9dbcb9d0b2fdccc054f0ab17
  Tag:       v135.2
  Branch:    None
  Version:   135.2
  Timestamp: None

INFO    src.main: Check finished with 0 error(s)

And here’s the relevant section of the manifest file:

      - type: git
        url: 'https://github.com/Anuken/Mindustry'
        tag: 'v135'
        commit: c24c5c6196cd89bdc17a079a2a8acd372cc260d9
        x-checker-data:
          type: git
          tag-pattern: '^v([0-9.]+)$'

Does the data checker take more time to go through all the flatpaks? Or did we fill out something wrong?

Here’s the manifest: com.github.Anuken.Mindustry/com.github.Anuken.Mindustry.yml at beta · flathub/com.github.Anuken.Mindustry · GitHub
And here is the issue discussing this problem: Didn't catch on v135.1 and v135.2 · Issue #40 · flathub/com.github.Anuken.Mindustry · GitHub

Thank you to any dev who can drop by and put an eye on it!

2

Oh, lol turns out flatpak-external-data-checker isn’t executed for non-default branches.